From: Mateusz Kulikowski Date: Wed, 12 Aug 2015 19:54:49 +0000 (+0200) Subject: staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit X-Git-Tag: v4.2.1~94 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef07b80a189eccb3b53b07993fcdcf933cbfe4b9;p=thirdparty%2Fkernel%2Fstable.git staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit commit 435009bba4d0449b611bc24ae5c9636ac5b2a00e upstream. This patch fixes issue generated by commit ca93dcba3a92 ("staging: rtl8192e: Remove assert() macro") One negation was missed in conversion, therefore asserted message was always printed. For 1MB file downloaded via http, ~500 messages were generated. Signed-off-by: Mateusz Kulikowski Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index c6cdb43b864c1..476808261fa8c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1826,8 +1826,8 @@ void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev, return; } - if (queue_index != TXCMD_QUEUE) - netdev_warn(dev, "%s(): queue index != TXCMD_QUEUE\n", + if (queue_index == TXCMD_QUEUE) + netdev_warn(dev, "%s(): queue index == TXCMD_QUEUE\n", __func__); memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));