From: Samuel Cabrero <scabrero@suse.de>
Date: Tue, 7 Jun 2022 09:06:04 +0000 (+0200)
Subject: s3:smbd: Free allocated strings before leaving user_in_netgroup() function
X-Git-Tag: tevent-0.13.0~464
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef1d04762afb6dd54ffb01020b7bf3236c86be0f;p=thirdparty%2Fsamba.git

s3:smbd: Free allocated strings before leaving user_in_netgroup() function

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun  9 22:40:43 UTC 2022 on sn-devel-184
---

diff --git a/source3/auth/user_util.c b/source3/auth/user_util.c
index f40123e246a..805f3ada231 100644
--- a/source3/auth/user_util.c
+++ b/source3/auth/user_util.c
@@ -165,11 +165,13 @@ bool user_in_netgroup(TALLOC_CTX *ctx, const char *user, const char *ngname)
 		return false;
 	}
 	if (!strlower_m(lowercase_user)) {
+		TALLOC_FREE(lowercase_user);
 		return false;
 	}
 
 	if (strcmp(user,lowercase_user) == 0) {
 		/* user name was already lower case! */
+		TALLOC_FREE(lowercase_user);
 		return false;
 	}
 
@@ -178,6 +180,7 @@ bool user_in_netgroup(TALLOC_CTX *ctx, const char *user, const char *ngname)
 
 	if (innetgr(ngname, NULL, lowercase_user, nis_domain)) {
 		DEBUG(5,("user_in_netgroup: Found\n"));
+		TALLOC_FREE(lowercase_user);
 		return true;
 	}
 #endif /* HAVE_NETGROUP */