From: Eric Blake <eblake@redhat.com>
Date: Thu, 2 Jun 2011 21:56:32 +0000 (-0600)
Subject: libvirtd: avoid leak on failure
X-Git-Tag: v0.9.2~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef21bedaf92f1d0399e3c20b9071086a255eeb47;p=thirdparty%2Flibvirt.git

libvirtd: avoid leak on failure

Spotted by Coverity.  Only possible on an OOM condition, so
unlikely to bite in the wild.

* daemon/libvirtd.c (qemudSetLogging): Don't leak memory.
---

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index aec81cf3f9..728031f0c2 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -2779,8 +2779,10 @@ qemudSetLogging(struct qemud_server *server, virConfPtr conf,
                     goto free_and_fail;
 
                 if (virAsprintf(&tmp, "%d:file:%s/.libvirt/libvirtd.log",
-                                virLogGetDefaultPriority(), userdir) == -1)
+                                virLogGetDefaultPriority(), userdir) == -1) {
+                    VIR_FREE(userdir);
                     goto out_of_memory;
+                }
             }
         } else {
             if (virAsprintf(&tmp, "%d:stderr", virLogGetDefaultPriority()) < 0)