From: Kamalesh Babulal Date: Tue, 15 Feb 2022 07:22:47 +0000 (+0530) Subject: test-027: make it PEP8 compliant X-Git-Tag: v3.1.0~308^2~2^2~77 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef40471c6696bbbc389fb983e54f89590d14f065;p=thirdparty%2Flibcgroup.git test-027: make it PEP8 compliant Make test 027-cgset-invalid_options.py PEP-8 compliant. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- diff --git a/ftests/027-cgset-invalid_options.py b/ftests/027-cgset-invalid_options.py index e5de8a18..001822dc 100755 --- a/ftests/027-cgset-invalid_options.py +++ b/ftests/027-cgset-invalid_options.py @@ -20,135 +20,155 @@ # along with this library; if not, see . # -from cgroup import Cgroup, CgroupVersion +from cgroup import Cgroup +from run import RunError import consts import ftests -import os -from run import RunError import sys +import os CONTROLLER = 'cpu' CGNAME1 = '027cgset1' CGNAME2 = '027cgset2' + def prereqs(config): result = consts.TEST_PASSED cause = None return result, cause + def setup(config): Cgroup.create(config, CONTROLLER, CGNAME1) Cgroup.create(config, CONTROLLER, CGNAME2) + def test(config): result = consts.TEST_PASSED cause = None try: # cgset -r cpu.shares=100 --copy-from 027cgset2 027cgset1 - Cgroup.set(config, cgname=CGNAME1, setting="cpu.shares", value="100", + Cgroup.set(config, cgname=CGNAME1, setting='cpu.shares', value='100', copy_from=CGNAME2) except RunError as re: - if not "Wrong input parameters," in re.stderr: + if 'Wrong input parameters,' not in re.stderr: result = consts.TEST_FAILED cause = "#1 Expected 'Wrong input parameters' to be in stderr" return result, cause if re.ret != 255: result = consts.TEST_FAILED - cause = "#1 Expected return code of 255 but received {}".format(re.ret) + cause = ( + '#1 Expected return code of 255 but received {}' + ''.format(re.ret) + ) return result, cause else: result = consts.TEST_FAILED - cause = "Test case #1 erroneously passed" + cause = 'Test case #1 erroneously passed' return result, cause try: # cgset -r cpu.shares=100 - Cgroup.set(config, cgname=None, setting="cpu.shares", value="100") + Cgroup.set(config, cgname=None, setting='cpu.shares', value='100') except RunError as re: - if not "cgset: no cgroup specified" in re.stderr: + if 'cgset: no cgroup specified' not in re.stderr: result = consts.TEST_FAILED cause = "#2 Expected 'no cgroup specified' to be in stderr" return result, cause if re.ret != 255: result = consts.TEST_FAILED - cause = "#2 Expected return code of 255 but received {}".format(re.ret) + cause = ( + '#2 Expected return code of 255 but received {}' + ''.format(re.ret) + ) return result, cause else: result = consts.TEST_FAILED - cause = "Test case #2 erroneously passed" + cause = 'Test case #2 erroneously passed' return result, cause try: # cgset 027cgset1 Cgroup.set(config, cgname=CGNAME1) except RunError as re: - if not "cgset: no name-value pair was set" in re.stderr: + if 'cgset: no name-value pair was set' not in re.stderr: result = consts.TEST_FAILED cause = "#3 Expected 'no name-value pair' to be in stderr" return result, cause if re.ret != 255: result = consts.TEST_FAILED - cause = "#3 Expected return code of 255 but received {}".format(re.ret) + cause = ( + '#3 Expected return code of 255 but received {}' + ''.format(re.ret) + ) return result, cause else: result = consts.TEST_FAILED - cause = "Test case #3 erroneously passed" + cause = 'Test case #3 erroneously passed' return result, cause try: # cgset - no flags provided Cgroup.set(config) except RunError as re: - if not "Usage is" in re.stderr: + if 'Usage is' not in re.stderr: result = consts.TEST_FAILED cause = "#4 Expected 'Usage is' to be in stderr" return result, cause if re.ret != 255: result = consts.TEST_FAILED - cause = "#4 Expected return code of 255 but received {}".format(re.ret) + cause = ( + '#4 Expected return code of 255 but received {}' + ''.format(re.ret) + ) return result, cause else: result = consts.TEST_FAILED - cause = "Test case #4 erroneously passed" + cause = 'Test case #4 erroneously passed' return result, cause try: # cgset -r cpu.shares= 027cgset1 - Cgroup.set(config, cgname=CGNAME1, setting="cpu.shares", value="") + Cgroup.set(config, cgname=CGNAME1, setting='cpu.shares', value='') except RunError as re: - if not "wrong parameter of option -r" in re.stderr: + if 'wrong parameter of option -r' not in re.stderr: result = consts.TEST_FAILED cause = "#5 Expected 'Wrong parameter of option' to be in stderr" return result, cause if re.ret != 255: result = consts.TEST_FAILED - cause = "#5 Expected return code of 255 but received {}".format(re.ret) + cause = ( + '#5 Expected return code of 255 but received {}' + ''.format(re.ret) + ) return result, cause else: result = consts.TEST_FAILED - cause = "Test case #5 erroneously passed" + cause = 'Test case #5 erroneously passed' return result, cause # cgset -h ret = Cgroup.set(config, cghelp=True) - if not "Usage:" in ret: + if 'Usage:' not in ret: result = consts.TEST_FAILED - cause = "#6 Failed to print help text" + cause = '#6 Failed to print help text' return result, cause return result, cause + def teardown(config): Cgroup.delete(config, CONTROLLER, CGNAME1) Cgroup.delete(config, CONTROLLER, CGNAME2) + def main(config): [result, cause] = prereqs(config) if result != consts.TEST_PASSED: @@ -160,6 +180,7 @@ def main(config): return [result, cause] + if __name__ == '__main__': config = ftests.parse_args() # this test was invoked directly. run only it