From: Peter Krempa Date: Mon, 26 Jul 2021 12:01:15 +0000 (+0200) Subject: qemu: capabilities: Note that basing probing on 'query-command-line-options' should... X-Git-Tag: v7.7.0-rc1~164 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef5f998a96b4b98cfff2b4ddf21a4e0ac9dfd5f6;p=thirdparty%2Flibvirt.git qemu: capabilities: Note that basing probing on 'query-command-line-options' should be avoided Add a comment that will attempt to discourage adding new capabilities based on 'query-command-line-options'. Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander Reviewed-by: Ján Tomko --- diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index adb15a89f2..4b303b660d 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3221,6 +3221,10 @@ struct virQEMUCapsCommandLineProps { int flag; }; + +/* This uses 'query-command-line-options' which uses old-style argument parsers + * in qemu and thus isn't being properly extended. Other means to detect + * features should be used if possible. */ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = { { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT }, { "boot-opts", "reboot-timeout", QEMU_CAPS_REBOOT_TIMEOUT },