From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 22 Feb 2022 01:15:43 +0000 (+1300)
Subject: auth: Cope with NULL upn_name in PAC
X-Git-Tag: tevent-0.12.0~623
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef95fb439237910b945b8d6a3ad4a140a8d6d1ea;p=thirdparty%2Fsamba.git

auth: Cope with NULL upn_name in PAC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14995

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c
index b5b6362dc93..fda014c87d5 100644
--- a/auth/auth_sam_reply.c
+++ b/auth/auth_sam_reply.c
@@ -616,11 +616,13 @@ NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx,
 	}
 
 	if (pac_upn_dns_info != NULL) {
-		user_info_dc->info->user_principal_name =
-			talloc_strdup(user_info_dc->info,
-				      pac_upn_dns_info->upn_name);
-		if (user_info_dc->info->user_principal_name == NULL) {
-			return NT_STATUS_NO_MEMORY;
+		if (pac_upn_dns_info->upn_name != NULL) {
+			user_info_dc->info->user_principal_name =
+				talloc_strdup(user_info_dc->info,
+					      pac_upn_dns_info->upn_name);
+			if (user_info_dc->info->user_principal_name == NULL) {
+				return NT_STATUS_NO_MEMORY;
+			}
 		}
 
 		user_info_dc->info->dns_domain_name =