From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Tue, 23 Feb 2010 00:07:17 +0000 (-0800)
Subject: Bug 486073: Make the JSON-RPC WebService throw errors properly under mod_perl
X-Git-Tag: bugzilla-3.7.1~225
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efa7ae77b14ad2d9caa34ce9cbed803dcde5bd95;p=thirdparty%2Fbugzilla.git

Bug 486073: Make the JSON-RPC WebService throw errors properly under mod_perl
r=dkl, a=mkanat
---

diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm
index 4e312b3edf..8e37101297 100644
--- a/Bugzilla/Error.pm
+++ b/Bugzilla/Error.pm
@@ -125,7 +125,9 @@ sub _throw_error {
                 # the internal JSON::RPC error codes.
                 $server->raise_error(code    => 100000 + $code,
                                      message => $message);
-                $server->response($server->error_response_header);
+                # We die with no message. JSON::RPC checks raise_error before
+                # it checks $@, so it returns the proper error.
+                die;
             }
         }
     }