From: Sami Kerola <kerolasa@iki.fi>
Date: Fri, 21 Nov 2014 23:11:31 +0000 (+0000)
Subject: lib/mbalign: fix unsigned integer overflow [AddressSanitizer]
X-Git-Tag: v2.26-rc1~123
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efb2fe5f5dc65d0d32444d9ad10e35dc2d6bc3a4;p=thirdparty%2Futil-linux.git

lib/mbalign: fix unsigned integer overflow [AddressSanitizer]

This error was reported 155 times.

lib/mbsalign.c:322:18: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'size_t' (aka 'unsigned long')

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/lib/mbsalign.c b/lib/mbsalign.c
index b307d19f7c..052fec611a 100644
--- a/lib/mbsalign.c
+++ b/lib/mbsalign.c
@@ -319,7 +319,7 @@ mbs_align_pad (char *dest, const char* dest_end, size_t n_spaces)
 {
   /* FIXME: Should we pad with "figure space" (\u2007)
      if non ascii data present?  */
-  while (n_spaces-- && (dest < dest_end))
+  for (/* nothing */; n_spaces && (dest < dest_end); n_spaces--)
     *dest++ = ' ';
   *dest = '\0';
   return dest;