From: Volker Lendecke <vl@samba.org>
Date: Thu, 16 Feb 2023 11:26:16 +0000 (+0100)
Subject: libsmb: Avoid a duplicate memset(.., 0, ..);
X-Git-Tag: talloc-2.4.1~1448
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efbfa9fc44bc56484dc4cc9cb93df6494dc06bc4;p=thirdparty%2Fsamba.git

libsmb: Avoid a duplicate memset(.., 0, ..);

tevent_req_create() does a talloc_zero() on "state" already

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index 13619c74209..45c8c96a036 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -958,7 +958,6 @@ static struct tevent_req *cli_posix_chown_chmod_internal_send(TALLOC_CTX *mem_ct
 	}
 
 	memset(state->data, 0xff, 40); /* Set all sizes/times to no change. */
-	memset(&state->data[40], '\0', 60);
 	SIVAL(state->data,40,uid);
 	SIVAL(state->data,48,gid);
 	SIVAL(state->data,84,mode);