From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 25 Jul 2014 11:15:47 +0000 (+0200)
Subject: qemu: Fix starting of VMs with empty CDROM drives
X-Git-Tag: v1.2.7-rc1~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efdb9117eec673d08ce289dd467ee2c3f5060806;p=thirdparty%2Flibvirt.git

qemu: Fix starting of VMs with empty CDROM drives

Since 24e5cafba6dbc2722e05f92dc0ae31b0f938f9f0 (thankfully unreleased)
when a VM with an empty disk drive would be started the code would call
stat() on NULL path as a check was missing from the callback rendering
machines unstartable.

Report success when the path is empty (denoting an empty drive).
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ca0d77f1f2..704ba3918e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -343,6 +343,9 @@ qemuSecurityChownCallback(virStorageSourcePtr src,
     if (virStorageSourceIsLocalStorage(src)) {
         /* use direct chmod for local files so that the file doesn't
          * need to be initialized */
+        if (!src->path)
+            return 0;
+
         if (stat(src->path, &sb) >= 0) {
             if (sb.st_uid == uid &&
                 sb.st_gid == gid) {