From: Pádraig Brady <P@draigBrady.com>
Date: Sun, 28 Jun 2015 02:53:51 +0000 (+0100)
Subject: maint: clarify df's use of device IDs from /proc/self/mountinfo
X-Git-Tag: v8.24~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eff511bd3cecaab30df75a854f01566ce45c5876;p=thirdparty%2Fcoreutils.git

maint: clarify df's use of device IDs from /proc/self/mountinfo

* src/df.c (filter_mount_list): Clarify why we still stat even
though devices IDs may already be available.  Note using
/proc/self/mountinfo is still an advantage to get filtered items
with accurate device patchs in chroots and with bind mounts.
I.E. on older setups with static /etc/mtab, df will now
bypass that to get the more accuracte and dynamic info.
---

diff --git a/src/df.c b/src/df.c
index 9d4c027404..2e541b952e 100644
--- a/src/df.c
+++ b/src/df.c
@@ -623,10 +623,8 @@ filter_mount_list (bool devices_only)
       struct mount_entry *discard_me = NULL;
 
       /* Avoid stating remote file systems as that may hang.
-         TODO: On Linux we might avoid this stat() and another in get_dev()
-         by using the device IDs available from /proc/self/mountinfo.
-         read_file_system_list() could populate me_dev from those
-         for efficiency and accuracy.  */
+         On Linux we probably have me_dev populated from /proc/self/mountinfo,
+         however we still stat() in case another device was mounted later.  */
       if ((me->me_remote && show_local_fs)
           || -1 == stat (me->me_mountdir, &buf))
         {