From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 31 Jan 2024 17:51:19 +0000 (+0000)
Subject: Minor Oracle fixes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eff7b0c24db3746ab2ef892a96bfc2683663e54a;p=thirdparty%2Ffreeradius-server.git

Minor Oracle fixes
---

diff --git a/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c b/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
index aaf327d37db..dbc618f877e 100644
--- a/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
+++ b/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
@@ -210,11 +210,11 @@ static int mod_bootstrap(module_inst_ctx_t const *mctx)
 	/*
 	 *	Create session pool
 	 */
-	DEBUG("OCISessionPoolCreate min=%d max=%d inc=%d", inst->spool_min, inst->spool_max, inst->spool_inc);
+	DEBUG2("OCISessionPoolCreate min=%d max=%d inc=%d", inst->spool_min, inst->spool_max, inst->spool_inc);
 
 	/* We need it to fix const issues between 'const char *' vs 'unsigned char *' */
-	memcpy(&sql_login, config->sql_login, sizeof(sql_login));
-	memcpy(&sql_password, config->sql_password, sizeof(sql_password));
+	memcpy(&sql_login, &config->sql_login, sizeof(sql_login));
+	memcpy(&sql_password, &config->sql_password, sizeof(sql_password));
 
 	if (OCISessionPoolCreate((dvoid *)inst->env, (dvoid *)inst->error, (dvoid *)inst->pool,
 				 (OraText**)&inst->pool_name, (ub4*)&inst->pool_name_len,