From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 21 Jul 2024 09:48:03 +0000 (+0200)
Subject: ci: call shellcheck on the bash script
X-Git-Tag: v24~7^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eff7ff7dfc35c4d3fe6620d08409aac1540c5297;p=thirdparty%2Fmkosi.git

ci: call shellcheck on the bash script

Sadly, shellcheck does not support zsh [1], and it's not even possible
to evaluate the script with zsh because it fails with:
  _arguments:comparguments:327: can only be called from completion function
So the zsh script shall not be checked.

[1] https://github.com/koalaman/shellcheck/issues/809
---

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2c06e80f5..3f71fe4f6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -78,10 +78,11 @@ jobs:
         ./builddir/mkosi -h
         ./builddir/mkosi documentation
 
-    - name: Test shell scripts
+    - name: Run shellcheck on scripts
       run: |
         sudo apt-get update && sudo apt-get install --no-install-recommends shellcheck
         bash -c 'shopt -s globstar; shellcheck bin/mkosi tools/*.sh'
+        bin/mkosi completion bash | shellcheck -
 
     - name: Test man page generation
       run: pandoc -s mkosi.md -o mkosi.1