From: Victor Julien <victor@inliniac.net>
Date: Tue, 17 Jun 2014 11:56:47 +0000 (+0200)
Subject: http: remove BUG_ON(1) statement
X-Git-Tag: suricata-2.0.2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eff85aba5e8c5b1f50a6da678f38beb808c7c9e2;p=thirdparty%2Fsuricata.git

http: remove BUG_ON(1) statement

Remove BUG_ON(1) statement that was a leftover from debugging.

Bug #1189
Bug #1212
---

diff --git a/src/app-layer-htp.c b/src/app-layer-htp.c
index 194b57971e..125ce3e1e1 100644
--- a/src/app-layer-htp.c
+++ b/src/app-layer-htp.c
@@ -781,11 +781,11 @@ static int HTPHandleResponseData(Flow *f, void *htp_state,
     HtpState *hstate = (HtpState *)htp_state;
     hstate->f = f;
     if (hstate->connp == NULL) {
-        SCLogError(SC_ERR_ALPARSER, "HTP state has no connp");
+        SCLogDebug("HTP state has no connp");
         /* till we have the new libhtp changes that allow response first,
          * let's take response in first. */
-        BUG_ON(1);
-        //SCReturnInt(-1);
+        //BUG_ON(1);
+        SCReturnInt(-1);
     }
 
     /* Unset the body inspection (the callback should