From: Dan Carpenter Date: Thu, 2 Aug 2018 08:24:47 +0000 (+0300) Subject: uio: potential double frees if __uio_register_device() fails X-Git-Tag: v4.19-rc1~100^2~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f019f07ecf6a6b8bd6d7853bce70925d90af02d1;p=thirdparty%2Fkernel%2Flinux.git uio: potential double frees if __uio_register_device() fails The uio_unregister_device() function assumes that if "info->uio_dev" is non-NULL that means "info" is fully allocated. Setting info->uio_de has to be the last thing in the function. In the current code, if request_threaded_irq() fails then we return with info->uio_dev set to non-NULL but info is not fully allocated and it can lead to double frees. Fixes: beafc54c4e2f ("UIO: Add the User IO core code") Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 3f76e38e6f303..15ad3469660de 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -953,8 +953,6 @@ int __uio_register_device(struct module *owner, if (ret) goto err_uio_dev_add_attributes; - info->uio_dev = idev; - if (info->irq && (info->irq != UIO_IRQ_CUSTOM)) { /* * Note that we deliberately don't use devm_request_irq @@ -971,6 +969,7 @@ int __uio_register_device(struct module *owner, goto err_request_irq; } + info->uio_dev = idev; return 0; err_request_irq: