From: Nicholas Nethercote <njn@valgrind.org>
Date: Wed, 16 Nov 2005 23:54:46 +0000 (+0000)
Subject: record more email comments
X-Git-Tag: svn/VALGRIND_3_1_0~76
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f02b8566009e910a76d2e25a439dca73ac5c0863;p=thirdparty%2Fvalgrind.git

record more email comments



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5156
---

diff --git a/coregrind/m_main.c b/coregrind/m_main.c
index b381a0645f..94345ec6a6 100644
--- a/coregrind/m_main.c
+++ b/coregrind/m_main.c
@@ -658,7 +658,10 @@ static void setup_client_dataseg ( SizeT max_size )
    vg_assert(ok);
 
    /* We make the data segment (heap) executable because LinuxThreads on
-      ppc32 creates trampolines in this area. */
+      ppc32 creates trampolines in this area.  Also, on x86/Linux the data
+      segment is RWX natively, at least according to /proc/self/maps.
+      Also, having a non-executable data seg would kill any program which
+      tried to create code in the data seg and then run it. */
    sres = VG_(am_mmap_anon_fixed_client)( 
              anon_start, 
              anon_size,