From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 18 Jul 2011 00:29:12 +0000 (+0200)
Subject: Bug 670128: Missing explicit exit after calls to $cgi->redirect(), making the rest... 
X-Git-Tag: bugzilla-4.0.2~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f036783e28c53160e73ed927ec43b160caec1b52;p=thirdparty%2Fbugzilla.git

Bug 670128: Missing explicit exit after calls to $cgi->redirect(), making the rest of the scripts to be executed
r=dkl a=LpSolit
---

diff --git a/post_bug.cgi b/post_bug.cgi
index a0cfaf29d8..8486ba032f 100755
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -55,7 +55,10 @@ my $vars = {};
 ######################################################################
 
 # redirect to enter_bug if no field is passed.
-print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi') unless $cgi->param();
+unless ($cgi->param()) {
+    print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi');
+    exit;
+}
 
 # Detect if the user already used the same form to submit a bug
 my $token = trim($cgi->param('token'));
diff --git a/relogin.cgi b/relogin.cgi
index 0e04b1bdc6..d31c809932 100755
--- a/relogin.cgi
+++ b/relogin.cgi
@@ -45,6 +45,7 @@ my $target;
 if (!$action) {
     # redirect to index.cgi if no action is defined.
     print $cgi->redirect(correct_urlbase() . 'index.cgi');
+    exit;
 }
 # prepare-sudo: Display the sudo information & login page
 elsif ($action eq 'prepare-sudo') {