From: JINMEI Tatuya Date: Thu, 4 Oct 2012 21:30:31 +0000 (-0700) Subject: [2284] minor comment update about in-memory finder context's getFinder(). X-Git-Tag: trac2351_base~8^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f037ebb23cb966f86d11c07bb0f4a80b6043c9b0;p=thirdparty%2Fkea.git [2284] minor comment update about in-memory finder context's getFinder(). with the cleanup in this ticket we can now actually return NULL, but intermediate status of other #2283 tickets will require non NULL values. So, it's probably better to keep the behavior with referring to #2283, instead of #2284. --- diff --git a/src/lib/datasrc/memory/zone_finder.cc b/src/lib/datasrc/memory/zone_finder.cc index 7b36521d59..86dd87428c 100644 --- a/src/lib/datasrc/memory/zone_finder.cc +++ b/src/lib/datasrc/memory/zone_finder.cc @@ -538,14 +538,14 @@ public: const RRClass& rrclass, const ZoneFinderResultContext& result) : ZoneFinder::Context(options, ResultContext(result.code, result.rrset, result.flags)), - finder_(finder), // NOTE: when #2284 is done we won't need this + finder_(finder), // NOTE: when entire #2283 is done we won't need this rrclass_(rrclass), zone_data_(result.zone_data), found_node_(result.found_node), found_rdset_(result.found_rdset) {} protected: - // When #2284 is done this can simply return NULL. + // When all tickets in #2283 are done this can simply return NULL. virtual ZoneFinder* getFinder() { return (&finder_); } // We don't use the default protected methods that rely on this method,