From: Noah Goldstein Date: Thu, 20 Oct 2022 02:13:37 +0000 (-0700) Subject: x86: Use `testb` for case-locale check in str{n}casecmp-sse42 X-Git-Tag: glibc-2.37~233 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f04f8373ddd71794050b904174fb06967be6393f;p=thirdparty%2Fglibc.git x86: Use `testb` for case-locale check in str{n}casecmp-sse42 `testb` saves a bit of code size is the imm-operand can be encoded 1-bytes. Tested on x86-64. --- diff --git a/sysdeps/x86_64/multiarch/strcmp-sse4_2.S b/sysdeps/x86_64/multiarch/strcmp-sse4_2.S index dc6fc90e14a..6b540ff894b 100644 --- a/sysdeps/x86_64/multiarch/strcmp-sse4_2.S +++ b/sysdeps/x86_64/multiarch/strcmp-sse4_2.S @@ -119,7 +119,7 @@ STRCMP: # else mov (%rdx), %RAX_LP # endif - testl $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) + testb $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) jne __strcasecmp_l_nonascii # endif # ifdef USE_AS_STRNCASECMP_L @@ -130,7 +130,7 @@ STRCMP: # else mov (%rcx), %RAX_LP # endif - testl $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) + testb $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) jne __strncasecmp_l_nonascii # endif