From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 6 Nov 2016 05:01:17 +0000 (-0400)
Subject: test-journal-importer: add a test case with broken input
X-Git-Tag: v233~89^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f06a6bcd761f2a643377b17c16776512404ac3b0;p=thirdparty%2Fsystemd.git

test-journal-importer: add a test case with broken input
---

diff --git a/Makefile.am b/Makefile.am
index fef13fabcd4..10839e922a1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2470,7 +2470,8 @@ test_journal_importer_LDADD = \
 	libsystemd-shared.la
 
 EXTRA_DIST += \
-	test/journal-data/journal-1.txt
+	test/journal-data/journal-1.txt \
+	test/journal-data/journal-2.txt
 
 # ------------------------------------------------------------------------------
 ## .PHONY so it always rebuilds it
diff --git a/src/test/test-journal-importer.c b/src/test/test-journal-importer.c
index fea5c1d51c4..1f0684863e9 100644
--- a/src/test/test-journal-importer.c
+++ b/src/test/test-journal-importer.c
@@ -44,7 +44,7 @@ static void test_basic_parsing(void) {
 
         do
                 r = journal_importer_process_data(&imp);
-        while (r == 0);
+        while (r == 0 && !journal_importer_eof(&imp));
         assert_se(r == 1);
 
         /* We read one entry, so we should get EOF on next read, but not yet */
@@ -64,11 +64,27 @@ static void test_basic_parsing(void) {
         assert_se(journal_importer_eof(&imp));
 }
 
+static void test_bad_input(void) {
+        _cleanup_(journal_importer_cleanup) JournalImporter imp = {};
+        int r;
+
+        imp.fd = open(TEST_DATA_DIR("/journal-data/journal-2.txt"), O_RDONLY|O_CLOEXEC);
+        assert_se(imp.fd >= 0);
+
+        do
+                r = journal_importer_process_data(&imp);
+        while (!journal_importer_eof(&imp));
+        assert_se(r == 0); /* If we don't have enough input, 0 is returned */
+
+        assert_se(journal_importer_eof(&imp));
+}
+
 int main(int argc, char **argv) {
         log_set_max_level(LOG_DEBUG);
         log_parse_environment();
 
         test_basic_parsing();
+        test_bad_input();
 
         return 0;
 }
diff --git a/test/journal-data/journal-2.txt b/test/journal-data/journal-2.txt
new file mode 100644
index 00000000000..4f582a0e889
Binary files /dev/null and b/test/journal-data/journal-2.txt differ