From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Tue, 7 Mar 2023 15:24:26 +0000 (+0100)
Subject: auth: sasl-server - Drop auth_new mechanism functions that have become trivial
X-Git-Tag: 2.4.2~249
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f07c79ff9d8ae1e05bcb52d70ec94d7bb6d45917;p=thirdparty%2Fdovecot%2Fcore.git

auth: sasl-server - Drop auth_new mechanism functions that have become trivial
---

diff --git a/src/auth/auth-sasl-mech-dovecot-token.c b/src/auth/auth-sasl-mech-dovecot-token.c
index dcb39107bf..7ccb00d26f 100644
--- a/src/auth/auth-sasl-mech-dovecot-token.c
+++ b/src/auth/auth-sasl-mech-dovecot-token.c
@@ -68,22 +68,12 @@ mech_dovecot_token_auth_continue(struct sasl_server_mech_request *request,
 		safe_memset(auth_token, 0, strlen(auth_token));
 }
 
-static struct sasl_server_mech_request *mech_dovecot_token_auth_new(pool_t pool)
-{
-	struct sasl_server_mech_request *request;
-
-	request = p_new(pool, struct sasl_server_mech_request, 1);
-
-	return request;
-}
-
 const struct sasl_server_mech_def mech_dovecot_token = {
 	.mech_name = "DOVECOT-TOKEN",
 
 	.flags = SASL_MECH_SEC_PRIVATE | SASL_MECH_SEC_ALLOW_NULS,
 	.passdb_need = SASL_MECH_PASSDB_NEED_NOTHING,
 
-	.auth_new = mech_dovecot_token_auth_new,
 	.auth_initial = sasl_server_mech_generic_auth_initial,
 	.auth_continue = mech_dovecot_token_auth_continue,
 };
diff --git a/src/auth/sasl-server-mech-anonymous.c b/src/auth/sasl-server-mech-anonymous.c
index f357726238..df90103514 100644
--- a/src/auth/sasl-server-mech-anonymous.c
+++ b/src/auth/sasl-server-mech-anonymous.c
@@ -19,22 +19,12 @@ mech_anonymous_auth_continue(struct sasl_server_mech_request *request,
 	sasl_server_request_success(request, "", 0);
 }
 
-static struct sasl_server_mech_request *mech_anonymous_auth_new(pool_t pool)
-{
-        struct sasl_server_mech_request *request;
-
-	request = p_new(pool, struct sasl_server_mech_request, 1);
-	request->pool = pool;
-	return request;
-}
-
 const struct sasl_server_mech_def mech_anonymous = {
 	.mech_name = "ANONYMOUS",
 
 	.flags = SASL_MECH_SEC_ANONYMOUS | SASL_MECH_SEC_ALLOW_NULS,
 	.passdb_need = SASL_MECH_PASSDB_NEED_NOTHING,
 
-	.auth_new = mech_anonymous_auth_new,
 	.auth_initial = sasl_server_mech_generic_auth_initial,
 	.auth_continue = mech_anonymous_auth_continue,
 };
diff --git a/src/auth/sasl-server-mech-external.c b/src/auth/sasl-server-mech-external.c
index 28d7792c31..4cc3d457e6 100644
--- a/src/auth/sasl-server-mech-external.c
+++ b/src/auth/sasl-server-mech-external.c
@@ -28,22 +28,12 @@ mech_external_auth_continue(struct sasl_server_mech_request *request,
 		request, "", sasl_server_mech_plain_verify_callback);
 }
 
-static struct sasl_server_mech_request *mech_external_auth_new(pool_t pool)
-{
-	struct sasl_server_mech_request *request;
-
-	request = p_new(pool, struct sasl_server_mech_request, 1);
-
-	return request;
-}
-
 const struct sasl_server_mech_def mech_external = {
 	.mech_name = "EXTERNAL",
 
 	.flags = 0,
 	.passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-	.auth_new = mech_external_auth_new,
 	.auth_initial = sasl_server_mech_generic_auth_initial,
 	.auth_continue = mech_external_auth_continue,
 };
diff --git a/src/auth/sasl-server-mech-login.c b/src/auth/sasl-server-mech-login.c
index 9637387f6a..799ff73873 100644
--- a/src/auth/sasl-server-mech-login.c
+++ b/src/auth/sasl-server-mech-login.c
@@ -51,22 +51,12 @@ mech_login_auth_initial(struct sasl_server_mech_request *request,
 	}
 }
 
-static struct sasl_server_mech_request *mech_login_auth_new(pool_t pool)
-{
-	struct sasl_server_mech_request *request;
-
-	request = p_new(pool, struct sasl_server_mech_request, 1);
-
-	return request;
-}
-
 const struct sasl_server_mech_def mech_login = {
 	.mech_name = "LOGIN",
 
 	.flags = SASL_MECH_SEC_PLAINTEXT,
 	.passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-	.auth_new = mech_login_auth_new,
 	.auth_initial = mech_login_auth_initial,
 	.auth_continue = mech_login_auth_continue,
 };
diff --git a/src/auth/sasl-server-mech-plain.c b/src/auth/sasl-server-mech-plain.c
index bb1172d416..c12c5bbee8 100644
--- a/src/auth/sasl-server-mech-plain.c
+++ b/src/auth/sasl-server-mech-plain.c
@@ -62,22 +62,12 @@ mech_plain_auth_continue(struct sasl_server_mech_request *request,
 		safe_memset(pass, 0, strlen(pass));
 }
 
-static struct sasl_server_mech_request *mech_plain_auth_new(pool_t pool)
-{
-	struct sasl_server_mech_request *request;
-
-	request = p_new(pool, struct sasl_server_mech_request, 1);
-
-	return request;
-}
-
 const struct sasl_server_mech_def mech_plain = {
 	.mech_name = "PLAIN",
 
 	.flags = SASL_MECH_SEC_PLAINTEXT | SASL_MECH_SEC_ALLOW_NULS,
 	.passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-	.auth_new = mech_plain_auth_new,
 	.auth_initial = sasl_server_mech_generic_auth_initial,
 	.auth_continue = mech_plain_auth_continue,
 };