From: Travis Cross <tc@traviscross.com>
Date: Sat, 25 May 2013 09:49:32 +0000 (+0000)
Subject: Handle a failure of strerror_r
X-Git-Tag: v1.2.13~321
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f07e58d30f9f8c396406a9795071f6fa4a837e34;p=thirdparty%2Ffreeswitch.git

Handle a failure of strerror_r

This fixes the build on gcc-4.7.3.  The build was breaking with:

  error: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Werror=unused-result]
---

diff --git a/libs/esl/src/esl.c b/libs/esl/src/esl.c
index 103f9156c9..af967de708 100644
--- a/libs/esl/src/esl.c
+++ b/libs/esl/src/esl.c
@@ -1287,7 +1287,8 @@ ESL_DECLARE(esl_status_t) esl_recv_event(esl_handle_t *handle, int check_q, esl_
 			}
 			continue;
 		} else if (rrval < 0) {
-			strerror_r(handle->errnum, handle->err, sizeof(handle->err));
+			if (!(strerror_r(handle->errnum, handle->err, sizeof(handle->err))))
+				*(handle->err)=0;
 			goto fail;
 		}
 
@@ -1319,7 +1320,8 @@ ESL_DECLARE(esl_status_t) esl_recv_event(esl_handle_t *handle, int check_q, esl_
 				*((char *)handle->socket_buf + ESL_CLAMP(0, sizeof(handle->socket_buf) - 1, r)) = '\0';
 
 				if (r < 0) {
-					strerror_r(handle->errnum, handle->err, sizeof(handle->err));
+					if (!(strerror_r(handle->errnum, handle->err, sizeof(handle->err))))
+						*(handle->err)=0;
 					goto fail;
 				} else if (r == 0) {
 					if (++zc >= 100) {
@@ -1464,14 +1466,16 @@ ESL_DECLARE(esl_status_t) esl_send(esl_handle_t *handle, const char *cmd)
 	
 	if (send(handle->sock, cmd, strlen(cmd), 0) != (int)strlen(cmd)) {
 		handle->connected = 0;
-		strerror_r(handle->errnum, handle->err, sizeof(handle->err));
+		if (!(strerror_r(handle->errnum, handle->err, sizeof(handle->err))))
+			*(handle->err)=0;
 		return ESL_FAIL;
 	}
 	
 	if (!(*e == '\n' && *(e-1) == '\n')) {
 		if (send(handle->sock, "\n\n", 2, 0) != 2) {
 			handle->connected = 0;
-			strerror_r(handle->errnum, handle->err, sizeof(handle->err));
+			if (!(strerror_r(handle->errnum, handle->err, sizeof(handle->err))))
+				*(handle->err)=0;
 			return ESL_FAIL;
 		}
 	}