From: George Joseph <gjoseph@digium.com>
Date: Thu, 9 Jun 2016 15:33:48 +0000 (-0600)
Subject: cdr.c: Remove assert in base_process_dial_end
X-Git-Tag: 14.0.0-beta1~120
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f0855358a64cea11567b64b4e8bf93aeb7ae1a73;p=thirdparty%2Fasterisk.git

cdr.c: Remove assert in base_process_dial_end

Scenario: Caller blonde transfer
Bob calls Charlie who answers.
Bob puts Charlie on hold and calls Alice.
Before Alice answers, Bob transfers Charlie to Alice.

Charlie's channel triggers an assert because he gets an "ANSWERED"
event even though he never dialed anything. With recent changes to dial
events, this is now a valid scenario so the assert needed to be removed.

ASTERISK-26103 #close

Change-Id: I2679b517b696e7952ab7fb29403df9140e7d1de2
---

diff --git a/main/cdr.c b/main/cdr.c
index b43e3610c0..8658710d52 100644
--- a/main/cdr.c
+++ b/main/cdr.c
@@ -1415,8 +1415,6 @@ static int base_process_bridge_leave(struct cdr_object *cdr, struct ast_bridge_s
 
 static int base_process_dial_end(struct cdr_object *cdr, struct ast_channel_snapshot *caller, struct ast_channel_snapshot *peer, const char *dial_status)
 {
-	/* In general, most things shouldn't get a dial end. */
-	ast_assert(0);
 	return 0;
 }