From: Bob Halley <halley@dnspython.org>
Date: Thu, 23 Jul 2020 14:12:20 +0000 (-0700)
Subject: Add serial branch coverage; remove duplicated test.
X-Git-Tag: v2.1.0rc1~153
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f08f1f87cf89dba5f61c644e818799b5e1dd9a2c;p=thirdparty%2Fdnspython.git

Add serial branch coverage; remove duplicated test.
---

diff --git a/tests/test_serial.py b/tests/test_serial.py
index d632a460..a9ef2df0 100644
--- a/tests/test_serial.py
+++ b/tests/test_serial.py
@@ -64,9 +64,6 @@ class SerialTestCase(unittest.TestCase):
     def test_sub(self):
         self.assertEqual(S8(0) - S8(1), S8(255))
 
-    def test_sub(self):
-        self.assertEqual(S8(0) - S8(1), S8(255))
-
     def test_addition_bounds(self):
         self.assertRaises(ValueError, lambda: S8(0) + 128)
         self.assertRaises(ValueError, lambda: S8(0) - 128)
@@ -100,6 +97,7 @@ class SerialTestCase(unittest.TestCase):
         self.assertRaises(ValueError, bad2)
 
     def test_uncomparable(self):
+        self.assertFalse(S8(0) == S2(0))
         self.assertFalse(S8(0) == 'a')
         self.assertTrue(S8(0) != 'a')
         self.assertRaises(TypeError, lambda: S8(0) < 'a')
@@ -113,3 +111,7 @@ class SerialTestCase(unittest.TestCase):
 
     def test_repr(self):
         self.assertEqual(repr(S8(1)), 'dns.serial.Serial(1, 8)')
+
+    def test_not_equal(self):
+        self.assertNotEqual(S8(0), S8(1))
+        self.assertNotEqual(S8(0), S2(0))