From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 30 Apr 2020 08:29:06 +0000 (+0200)
Subject: rec: Fix 'loop variable [...] creates a copy' warnings
X-Git-Tag: dnsdist-1.5.0-rc2~3^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f0c604d5b652c6886ba880ab281290a89cda324e;p=thirdparty%2Fpdns.git

rec: Fix 'loop variable [...] creates a copy' warnings

Reported by clang++ 10.
---

diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc
index 087be580a5..2de0102ac2 100644
--- a/pdns/filterpo.cc
+++ b/pdns/filterpo.cc
@@ -626,15 +626,15 @@ void DNSFilterEngine::Zone::dump(FILE* fp) const
     dumpNamedPolicy(fp, pair.first + DNSName("rpz-nsdname.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_qpolAddr) {
+  for (const auto& pair : d_qpolAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-client-ip.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_propolNSAddr) {
+  for (const auto& pair : d_propolNSAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-nsip.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_postpolAddr) {
+  for (const auto& pair : d_postpolAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-ip.") + d_domain, pair.second);
   }
 }
diff --git a/pdns/recursordist/test-syncres_cc.cc b/pdns/recursordist/test-syncres_cc.cc
index f7a06bb1a4..1eec4369cd 100644
--- a/pdns/recursordist/test-syncres_cc.cc
+++ b/pdns/recursordist/test-syncres_cc.cc
@@ -279,7 +279,7 @@ bool addRRSIG(const testkeysset_t& keys, std::vector<DNSRecord>& records, const
   const uint16_t type = records[recordsCount - 1].d_type;
 
   sortedRecords_t recordcontents;
-  for (const auto record : records) {
+  for (const auto& record : records) {
     if (record.d_name == name && record.d_type == type) {
       recordcontents.insert(record.d_content);
     }