From: minfrin <minfrin@users.noreply.github.com>
Date: Mon, 25 Oct 2021 14:39:35 +0000 (+0200)
Subject: ChangeLog: snmp plugin: Add support for SHA224, SHA256, SHA384 and SHA512.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f0d63c0a55850bcc06c3179f597349cbb905b306;p=thirdparty%2Fcollectd.git

ChangeLog: snmp plugin: Add support for SHA224, SHA256, SHA384 and SHA512.
---

diff --git a/src/snmp.c b/src/snmp.c
index 17e4b4cf4..401de7414 100644
--- a/src/snmp.c
+++ b/src/snmp.c
@@ -674,22 +674,97 @@ static int csnmp_config_add_host_auth_protocol(host_definition_t *hd,
   if (status != 0)
     return status;
 
+#ifdef NETSNMP_USMAUTH_HMACMD5
   if (strcasecmp("MD5", buffer) == 0) {
     hd->auth_protocol = usmHMACMD5AuthProtocol;
     hd->auth_protocol_len = sizeof(usmHMACMD5AuthProtocol) / sizeof(oid);
-  } else if (strcasecmp("SHA", buffer) == 0) {
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name, "MD5");
+    return 0;
+  }
+#endif
+
+#ifdef NETSNMP_USMAUTH_HMACSHA1
+  if (strcasecmp("SHA", buffer) == 0) {
     hd->auth_protocol = usmHMACSHA1AuthProtocol;
     hd->auth_protocol_len = sizeof(usmHMACSHA1AuthProtocol) / sizeof(oid);
-  } else {
-    WARNING("snmp plugin: The `AuthProtocol' config option must be `MD5' or "
-            "`SHA'.");
-    return -1;
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name, "SHA");
+
+    return 0;
   }
+#endif
 
-  DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name,
-        hd->auth_protocol == usmHMACMD5AuthProtocol ? "MD5" : "SHA");
+#ifdef NETSNMP_USMAUTH_HMAC128SHA224
+  if (strcasecmp("SHA224", buffer) == 0) {
+    hd->auth_protocol = usmHMAC128SHA224AuthProtocol;
+    hd->auth_protocol_len = sizeof(usmHMAC128SHA224AuthProtocol) / sizeof(oid);
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name,
+          "SHA224");
+
+    return 0;
+  }
+#endif
+
+#ifdef NETSNMP_USMAUTH_HMAC192SHA256
+  if (strcasecmp("SHA256", buffer) == 0) {
+    hd->auth_protocol = usmHMAC192SHA256AuthProtocol;
+    hd->auth_protocol_len = sizeof(usmHMAC192SHA256AuthProtocol) / sizeof(oid);
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name,
+          "SHA256");
+
+    return 0;
+  }
+#endif
+
+#ifdef NETSNMP_USMAUTH_HMAC256SHA384
+  if (strcasecmp("SHA384", buffer) == 0) {
+    hd->auth_protocol = usmHMAC256SHA384AuthProtocol;
+    hd->auth_protocol_len = sizeof(usmHMAC256SHA384AuthProtocol) / sizeof(oid);
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name,
+          "SHA384");
+
+    return 0;
+  }
+#endif
+
+#ifdef NETSNMP_USMAUTH_HMAC384SHA512
+  if (strcasecmp("SHA512", buffer) == 0) {
+    hd->auth_protocol = usmHMAC384SHA512AuthProtocol;
+    hd->auth_protocol_len = sizeof(usmHMAC384SHA512AuthProtocol) / sizeof(oid);
+
+    DEBUG("snmp plugin: host = %s; host->auth_protocol = %s;", hd->name,
+          "SHA512");
+
+    return 0;
+  }
+#endif
+
+  WARNING("snmp plugin: The `AuthProtocol' config option must be:"
+#ifdef NETSNMP_USMAUTH_HMACMD5
+          " MD5"
+#endif
+#ifdef NETSNMP_USMAUTH_HMACSHA1
+          " SHA"
+#endif
+#ifdef NETSNMP_USMAUTH_HMAC128SHA224
+          " SHA224"
+#endif
+#ifdef NETSNMP_USMAUTH_HMAC192SHA256
+          " SHA256"
+#endif
+#ifdef NETSNMP_USMAUTH_HMAC256SHA384
+          " SHA384"
+#endif
+#ifdef NETSNMP_USMAUTH_HMAC384SHA512
+          " SHA512"
+#endif
+  );
+  return -1;
 
-  return 0;
 } /* int csnmp_config_add_host_auth_protocol */
 
 static int csnmp_config_add_host_priv_protocol(host_definition_t *hd,