From: Tim Kientzle <kientzle@gmail.com>
Date: Thu, 24 Sep 2009 15:25:56 +0000 (-0400)
Subject: Add a TODO comment to remind me to come back and
X-Git-Tag: v2.8.0~338
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f0dfc9095b764a4f7cfc9e18c09eab379eb1b104;p=thirdparty%2Flibarchive.git

Add a TODO comment to remind me to come back and
work on the remaining issues caused by Windows broken
stat().

SVN-Revision: 1470
---

diff --git a/libarchive/archive_read_disk_entry_from_file.c b/libarchive/archive_read_disk_entry_from_file.c
index 6ebd67384..a8337650e 100644
--- a/libarchive/archive_read_disk_entry_from_file.c
+++ b/libarchive/archive_read_disk_entry_from_file.c
@@ -114,6 +114,11 @@ archive_read_disk_entry_from_file(struct archive *_a,
 #endif
 
 	if (st == NULL) {
+		/* TODO: On Windows, use GetFileInfoByHandle() here.
+		 * Using Windows stat() call is badly broken, but
+		 * even the stat() wrapper has problems because
+		 * 'struct stat' is broken on Windows.
+		 */
 #if HAVE_FSTAT
 		if (fd >= 0) {
 			if (fstat(fd, &s) != 0)