From: Christian Ruppert <idl0r@gentoo.org>
Date: Thu, 10 Jul 2014 08:31:35 +0000 (+0100)
Subject: Bug 856598 - checksetup.pl should exit(1) if it fails checks. r=gerv, a=sgreen.
X-Git-Tag: bugzilla-4.5.5~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f0f51946bab6b9c85c5ebd6fc737538ce967af59;p=thirdparty%2Fbugzilla.git

Bug 856598 - checksetup.pl should exit(1) if it fails checks. r=gerv, a=sgreen.
---

diff --git a/checksetup.pl b/checksetup.pl
index c93071b88a..145faf04e3 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -51,14 +51,14 @@ my $answers_file = $ARGV[0];
 my $silent = $answers_file && !$switch{'verbose'};
 
 print(install_string('header', get_version_and_os()) . "\n") unless $silent;
-exit if $switch{'version'};
+exit 0 if $switch{'version'};
 # Check required --MODULES--
 my $module_results = check_requirements(!$silent);
 Bugzilla::Install::Requirements::print_module_instructions(
     $module_results, !$silent);
-exit if !$module_results->{pass};
+exit 1 if !$module_results->{pass};
 # Break out if checking the modules is all we have been asked to do.
-exit if $switch{'check-modules'};
+exit 0 if $switch{'check-modules'};
 
 ###########################################################################
 # Load Bugzilla Modules