From: Michael Schroeder <mls@suse.de>
Date: Wed, 30 Apr 2008 16:53:46 +0000 (+0000)
Subject: - speed up solver a bit by creating a queue holding all assertion
X-Git-Tag: BASE-SuSE-Code-12_1-Branch~308^2~375
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f106cfdb0ae4d147759d1a885aa90ce428d9be37;p=thirdparty%2Flibsolv.git

- speed up solver a bit by creating a queue holding all assertion
  rules, so we do not have to scan all rules for assertions
---

diff --git a/src/solver.c b/src/solver.c
index 3a111153..1dac8d7c 100644
--- a/src/solver.c
+++ b/src/solver.c
@@ -508,7 +508,7 @@ static void
 makeruledecisions(Solver *solv)
 {
   Pool *pool = solv->pool;
-  int i, ri;
+  int i, ri, ii;
   Rule *r, *rr;
   Id v, vv;
   int decisionstart;
@@ -516,12 +516,10 @@ makeruledecisions(Solver *solv)
   POOL_DEBUG(SAT_DEBUG_SCHUBI, "----- makeruledecisions ; size decisionq: %d -----\n",solv->decisionq.count);
 
   decisionstart = solv->decisionq.count;
-  /* rpm rules don't have assertions, so we can start with the job
-   * rules (rpm assertions are not resulting in a rule, but cause a
-   * immediate decision) */
-  /* nowadays they can be weak, so start with rule 1 */
-  for (ri = 1, r = solv->rules + ri; ri < solv->nrules; ri++, r++)
+  for (ii = 0; ii < solv->ruleassertions.count; ii++)
     {
+      ri = solv->ruleassertions.elements[ii];
+      r = solv->rules + ri;
       if (r->d < 0 || !r->p || r->w2)	/* disabled, dummy or no assertion */
 	continue;
       /* do weak rules in phase 2 */
@@ -636,13 +634,14 @@ makeruledecisions(Solver *solv)
 	  vv = v > 0 ? v : -v;
 	  solv->decisionmap[vv] = 0;
 	}
-      ri = solv->jobrules - 1;
-      r = solv->rules + ri;
+      ii = -1;
     }
 
   /* phase 2: now do the weak assertions */
-  for (ri = 1, r = solv->rules + ri; ri < solv->learntrules; ri++, r++)
+  for (ii = 0; ii < solv->ruleassertions.count; ii++)
     {
+      ri = solv->ruleassertions.elements[ii];
+      r = solv->rules + ri;
       if (r->d < 0 || r->w2)	/* disabled or no assertion */
 	continue;
       if (!MAPTST(&solv->weakrulemap, ri))
@@ -1904,6 +1903,11 @@ setpropagatelearn(Solver *solv, int level, Id decision, int disablerules)
 	  watch2onhighest(solv, r);
 	  addwatches_rule(solv, r);
 	}
+      else
+	{
+	  /* learnt rule is an assertion */
+          queue_push(&solv->ruleassertions, r - solv->rules);
+	}
       solv->decisionmap[p > 0 ? p : -p] = p > 0 ? level : -level;
       queue_push(&solv->decisionq, p);
       queue_push(&solv->decisionq_why, r - solv->rules);
@@ -1994,6 +1998,7 @@ solver_create(Pool *pool, Repo *installed)
   queue_init(&solv->branches);
   queue_init(&solv->covenantq);
   queue_init(&solv->weakruleq);
+  queue_init(&solv->ruleassertions);
 
   map_init(&solv->recommendsmap, pool->nsolvables);
   map_init(&solv->suggestsmap, pool->nsolvables);
@@ -2027,6 +2032,7 @@ solver_free(Solver *solv)
   queue_free(&solv->branches);
   queue_free(&solv->covenantq);
   queue_free(&solv->weakruleq);
+  queue_free(&solv->ruleassertions);
 
   map_free(&solv->recommendsmap);
   map_free(&solv->suggestsmap);
@@ -3608,6 +3614,12 @@ solver_solve(Solver *solv, Queue *job)
   /* all new rules are learnt after this point */
   solv->learntrules = solv->nrules;
 
+  /* create assertion index. it is only used to speed up
+   * makeruledecsions() a bit */
+  for (i = 1, r = solv->rules + i; i < solv->nrules; i++, r++)
+    if (r->p && !r->w2 && (r->d == 0 || r->d == -1))
+      queue_push(&solv->ruleassertions, i);
+
   /* disable update rules that conflict with our job */
   disableupdaterules(solv, job, -1);
 
diff --git a/src/solver.h b/src/solver.h
index d321e632..5e9ef527 100644
--- a/src/solver.h
+++ b/src/solver.h
@@ -66,6 +66,8 @@ typedef struct solver {
   Rule *rules;				/* all rules */
   Id nrules;				/* index of the last rule */
 
+  Queue ruleassertions;			/* index of all assertion rules */
+
   Id jobrules;				/* user rules */
   Id updaterules;			/* policy rules, e.g. keep packages installed or update. All literals > 0 */
   Id featurerules;			/* feature rules */