From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sat, 9 Nov 2024 23:54:55 +0000 (+0200)
Subject: dbus-hash: Fix RANDOM_INDEX signed-integer-overflow on 32-bit
X-Git-Tag: dbus-1.15.90~7^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f10e92244aecde2e80265f7c1f2a5c1f0187ece1;p=thirdparty%2Fdbus.git

dbus-hash: Fix RANDOM_INDEX signed-integer-overflow on 32-bit

Found by compiling with clang -fsanitize=signed-integer-overflow etc and
running dbus-daemon on armv7.

Signed-off-by: Jami Kettunen <jami.kettunen@protonmail.com>
---

diff --git a/dbus/dbus-hash.c b/dbus/dbus-hash.c
index 2635a1546..20a0230c7 100644
--- a/dbus/dbus-hash.c
+++ b/dbus/dbus-hash.c
@@ -127,7 +127,7 @@
  * 
  */
 #define RANDOM_INDEX(table, i) \
-    (((((intptr_t) (i))*1103515245) >> (table)->down_shift) & (table)->mask)
+    (((((uintptr_t) (i))*1103515245) >> (table)->down_shift) & (table)->mask)
 
 /**
  * Initial number of buckets in hash table (hash table statically