From: Jeremy Allison <jra@samba.org>
Date: Wed, 26 Aug 2020 20:45:43 +0000 (-0700)
Subject: s3: libsmb: discover_dc_netbios(). Remember to free on error return.
X-Git-Tag: talloc-2.3.2~636
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f11dce99cc3a3e0b13fcb0d41d2db5cce07240db;p=thirdparty%2Fsamba.git

s3: libsmb: discover_dc_netbios(). Remember to free on error return.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index 128004a0f6a..9d7d430c921 100644
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -443,7 +443,7 @@ static NTSTATUS discover_dc_netbios(TALLOC_CTX *mem_ctx,
 {
 	NTSTATUS status;
 	enum nbt_name_type name_type = NBT_NAME_LOGON;
-	struct ip_service *iplist;
+	struct ip_service *iplist = NULL;
 	int i;
 	struct ip_service_name *dclist = NULL;
 	int count;
@@ -481,11 +481,13 @@ static NTSTATUS discover_dc_netbios(TALLOC_CTX *mem_ctx,
 		ok = sockaddr_storage_to_samba_sockaddr(&r->sa, &iplist[i].ss);
 		if (!ok) {
 			SAFE_FREE(iplist);
+			TALLOC_FREE(dclist);
 			return NT_STATUS_INVALID_PARAMETER;
 		}
 		r->hostname = talloc_strdup(mem_ctx, addr);
 		if (!r->hostname) {
 			SAFE_FREE(iplist);
+			TALLOC_FREE(dclist);
 			return NT_STATUS_NO_MEMORY;
 		}