From: Andrei Pavel Date: Mon, 17 Jun 2024 17:46:54 +0000 (+0300) Subject: [#3287] address review X-Git-Tag: Kea-2.7.0~18 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f11dd59433928e1f717f8e6ec76f92c19eb0636c;p=thirdparty%2Fkea.git [#3287] address review --- diff --git a/src/bin/shell/tests/tls_ca_process_tests.sh.in b/src/bin/shell/tests/tls_ca_process_tests.sh.in index 2ece6c6c61..d72564075a 100644 --- a/src/bin/shell/tests/tls_ca_process_tests.sh.in +++ b/src/bin/shell/tests/tls_ca_process_tests.sh.in @@ -152,14 +152,14 @@ list_commands_test() { # shellcheck disable=SC2086 # SC2086: Double quote to prevent globbing and word splitting. - # Reason: we spcifically want ${arguments} to split because there may be multiple words in it. + # Reason: we specifically want ${arguments} to split because there may be multiple words in it. tmp="echo | ${shell_bin_path}/${shell_bin} --port 8443 \ ${arguments} > ${tmpfile_path}/shell-stdout.txt" echo "Executing kea-shell ($tmp)" # shellcheck disable=SC2086 # SC2086: Double quote to prevent globbing and word splitting. - # Reason: we spcifically want ${arguments} to split because there may be multiple words in it. + # Reason: we specifically want ${arguments} to split because there may be multiple words in it. echo | ${shell_bin_path}/${shell_bin} --port 8443 \ ${arguments} > ${tmpfile_path}/shell-stdout.txt EXIT_CODE=$? diff --git a/tools/check-for-json-errors-in-doc.sh b/tools/check-for-json-errors-in-doc.sh index 764827e5c6..42cc54bf19 100755 --- a/tools/check-for-json-errors-in-doc.sh +++ b/tools/check-for-json-errors-in-doc.sh @@ -90,7 +90,7 @@ for file in ${files}; do # 4. replace all '[ ]' with '[ "" ]' where DATA contains: '-' and 'A-Za-z0-9' and ' ' # 5. replace all ' :' with ' "":' # 6. replace all ': ' with ': ""' - # 7. replace ' ...' with ' "placeholder": "value" + # 7. replace ' ...' with ' "placeholder": "value"' # 8. replace ', ... ' with ' ' # 9. replace ' ' with ' "placeholder": "value"' # 10. replace ' ' with ' "placeholder"' diff --git a/tools/extract_bnf.sh.in b/tools/extract_bnf.sh.in index 02c69e3335..96767936a9 100644 --- a/tools/extract_bnf.sh.in +++ b/tools/extract_bnf.sh.in @@ -85,7 +85,7 @@ $header EOF # shellcheck disable=SC2016 # SC2016: Expressions don't expand in single quotes, use double quotes for that. - # Reason: we spcifically do not want $0 to expand. + # Reason: we specifically do not want $0 to expand. @AWK@ '/^.+$/ { print " ",$0 }; /^$/ { print } ' $output.2 >> $output.3 cat $output.3 else