From: William A. Rowe Jr <wrowe@apache.org>
Date: Tue, 18 Dec 2001 15:09:47 +0000 (+0000)
Subject:   Revert the code causing lost path_info/query_args.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f1356395eab53b633f7b964e7931af09842e8e1d;p=thirdparty%2Fapache%2Fhttpd.git

  Revert the code causing lost path_info/query_args.

  The potentially correct solution is to test the URI with recombined
  path_info and args, but I'd rather see this reverted for 1.3 and
  corrected in 2.0 with appropriate optimizations and user testing.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@92514 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/modules/standard/mod_negotiation.c b/src/modules/standard/mod_negotiation.c
index f32be3b342a..3fad90dd6f6 100644
--- a/src/modules/standard/mod_negotiation.c
+++ b/src/modules/standard/mod_negotiation.c
@@ -2710,8 +2710,19 @@ static int handle_multi(request_rec *r)
      */
     ap_pool_join(r->pool, sub_req->pool);
     r->mtime = 0; /* reset etag info for subrequest */
-    r->uri = sub_req->uri;
-    r->args = sub_req->args;
+    /* XXX: uri/args/path_info are all retained from the original request.
+     *      It is entirely possible, but not common, for a handler to choke
+     *      on some expectation based on the uri (or more commonly, args) that 
+     *      the file subrequest was prepared to handle, but a lookup_uri would
+     *      have considered an error.  This leaves an improbable possibility 
+     *      that the user might fail a mod_dir request later, and the server 
+     *      may respond with a mod_autoindex response.  However, this has been
+     *      the behavior throughout much of the Apache 1.3 era with minimal
+     *      side effects, mostly caused by obscure configuration bugs.
+     *  r->uri = sub_req->uri;
+     *  r->args = sub_req->args;
+     *  r->path_info = sub_req->path_info;  
+     */
     r->filename = sub_req->filename;
     r->handler = sub_req->handler;
     r->content_type = sub_req->content_type;