From: David Lechner Date: Thu, 19 Mar 2026 20:00:10 +0000 (-0500) Subject: arm: mediatek: mt8188: remove call to fdtdec_setup_memory_banksize() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f14635b20aaae702b3cc0b420eec88e9b5dd3dda;p=thirdparty%2Fu-boot.git arm: mediatek: mt8188: remove call to fdtdec_setup_memory_banksize() Remove an incorrect call to fdtdec_setup_memory_banksize() in dram_init() for mt8188. fdtdec_setup_memory_banksize() populates gd->bd->bi_dram[bank].start and gd->bd->bi_dram[bank].size base on the "memory" node in the device tree. However, calling it from dram_init() is too early because gd->bd has not been allocated yet. gd->bd->bi_dram[0].start and gd->bd->bi_dram[0].size are already correctly initialized later in dram_init_banksize(), so we do not need to replace the removed function call with anything else. Reviewed-by: Julien Stephan Tested-by: Julien Stephan Link: https://patch.msgid.link/20260319-mtk-init-fix-dram-v1-7-6171ec141f40@baylibre.com Signed-off-by: David Lechner --- diff --git a/arch/arm/mach-mediatek/mt8188/init.c b/arch/arm/mach-mediatek/mt8188/init.c index 8f0db7455ed..fc80bc92bd8 100644 --- a/arch/arm/mach-mediatek/mt8188/init.c +++ b/arch/arm/mach-mediatek/mt8188/init.c @@ -18,10 +18,6 @@ int dram_init(void) { int ret; - ret = fdtdec_setup_memory_banksize(); - if (ret) - return ret; - ret = fdtdec_setup_mem_size_base(); if (ret) return ret;