From: Pauli <ppzgs1@gmail.com>
Date: Wed, 17 Mar 2021 03:09:06 +0000 (+1000)
Subject: test: coverity 1469426 - dereference after null check
X-Git-Tag: openssl-3.0.0-alpha14~179
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f1619160c89d5394f0cb9626d1198ef5180448db;p=thirdparty%2Fopenssl.git

test: coverity 1469426 - dereference after null check

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14589)
---

diff --git a/test/sslapitest.c b/test/sslapitest.c
index b469d80a176..d46e73b3127 100644
--- a/test/sslapitest.c
+++ b/test/sslapitest.c
@@ -8297,7 +8297,7 @@ static EVP_PKEY *get_tmp_dh_params(void)
         OSSL_PARAM_BLD_free_params(params);
     }
 
-    if (!EVP_PKEY_up_ref(tmp_dh_params))
+    if (tmp_dh_params != NULL && !EVP_PKEY_up_ref(tmp_dh_params))
         return NULL;
 
     return tmp_dh_params;