From: Arnd Bergmann Date: Wed, 4 Oct 2017 13:34:55 +0000 (+0200) Subject: imx-media-of: avoid uninitialized variable warning X-Git-Tag: v4.13.6~160 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f169d0276839cd81fc3a539ffdd7cad90fb112e4;p=thirdparty%2Fkernel%2Fstable.git imx-media-of: avoid uninitialized variable warning Replaces upstream commit 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") We get a harmless warning about a potential uninitialized variable use in the driver: drivers/staging/media/imx/imx-media-of.c: In function 'of_parse_subdev': drivers/staging/media/imx/imx-media-of.c:216:4: warning: 'remote_np' may be used uninitialized in this function [-Wmaybe-uninitialized] I reworked that code to be easier to understand by gcc in mainline, but that commit is too large to backport. This is a much simpler workaround, avoiding the warning by adding a fake initialization to the variable. The driver was only introduced in linux-4.13, so the workaround is not needed for earlier stable kernels. Fixes: e130291212df ("[media] media: Add i.MX media core driver") Cc: stable@vger.kernel.org Cc: Philipp Zabel Cc: Steve Longerbeam Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c index b026fe66467c4..90e7e702a411c 100644 --- a/drivers/staging/media/imx/imx-media-of.c +++ b/drivers/staging/media/imx/imx-media-of.c @@ -167,7 +167,7 @@ of_parse_subdev(struct imx_media_dev *imxmd, struct device_node *sd_np, of_parse_sensor(imxmd, imxsd, sd_np); for (i = 0; i < num_pads; i++) { - struct device_node *epnode = NULL, *port, *remote_np; + struct device_node *epnode = NULL, *port, *remote_np = NULL; struct imx_media_subdev *remote_imxsd; struct imx_media_pad *pad; int remote_pad;