From: Bob Halley <halley@play-bow.org>
Date: Wed, 1 Jul 2020 03:41:48 +0000 (-0700)
Subject: more query coverage
X-Git-Tag: v2.0.0rc2~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f1ad0e795e902f8dee675392980ae55c501c6007;p=thirdparty%2Fdnspython.git

more query coverage
---

diff --git a/tests/test_query.py b/tests/test_query.py
index 895dc0d7..19d68ecf 100644
--- a/tests/test_query.py
+++ b/tests/test_query.py
@@ -16,6 +16,7 @@
 # OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 import socket
+import time
 import unittest
 
 try:
@@ -236,6 +237,31 @@ class DestinationAndSourceTests(unittest.TestCase):
         (af, d, s) = _d_and_s('1::2', 53, None, 12345)
         self.assertEqual(s, ('::', 12345, 0, 0))
 
+
+class AddressesEqualTestCase(unittest.TestCase):
+
+    def test_v4(self):
+        self.assertTrue(dns.query._addresses_equal(socket.AF_INET,
+                                                   ('10.0.0.1', 53),
+                                                   ('10.0.0.1', 53)))
+        self.assertFalse(dns.query._addresses_equal(socket.AF_INET,
+                                                    ('10.0.0.1', 53),
+                                                    ('10.0.0.2', 53)))
+
+    def test_v6(self):
+        self.assertTrue(dns.query._addresses_equal(socket.AF_INET6,
+                                                   ('1::1', 53),
+                                                   ('0001:0000::1', 53)))
+        self.assertFalse(dns.query._addresses_equal(socket.AF_INET6,
+                                                   ('::1', 53),
+                                                   ('::2', 53)))
+
+    def test_mixed(self):
+        self.assertFalse(dns.query._addresses_equal(socket.AF_INET,
+                                                    ('10.0.0.1', 53),
+                                                    ('::2', 53)))
+
+
 axfr_zone = '''
 $ORIGIN example.
 $TTL 300
@@ -482,3 +508,34 @@ class TsigTests(unittest.TestCase):
             self.assertTrue(rrs is not None)
             seen = set([rdata.address for rdata in rrs])
             self.assertTrue('1.2.3.4' in seen)
+
+class LowLevelWaitTests(unittest.TestCase):
+
+    def test_wait_for(self):
+        try:
+            (l, r) = socket.socketpair()
+            # already expired
+            with self.assertRaises(dns.exception.Timeout):
+                dns.query._wait_for(l, True, True, True, 0)
+            # simple timeout
+            with self.assertRaises(dns.exception.Timeout):
+                dns.query._wait_for(l, False, False, False, time.time() + 0.05)
+            # writable no timeout (not hanging is passing)
+            dns.query._wait_for(l, False, True, False, None)
+        finally:
+            l.close()
+            r.close()
+
+    def test_select_for(self):
+        # we test this explicitly in case _wait_for didn't test it (i.e.
+        # if the default polling backing is _poll_for)
+        try:
+            (l, r) = socket.socketpair()
+            # simple timeout
+            self.assertFalse(dns.query._select_for(l, False, False, False,
+                                                   0.05))
+            # writable no timeout
+            self.assertTrue(dns.query._select_for(l, False, True, False, None))
+        finally:
+            l.close()
+            r.close()