From: Jakub Jelinek Date: Wed, 3 Apr 2013 17:52:33 +0000 (+0200) Subject: backport: re PR middle-end/52547 (ICE with openmp with nested function which requires... X-Git-Tag: releases/gcc-4.6.4~71 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f1e5c27260f3ad45df0012f154dc90b834235aab;p=thirdparty%2Fgcc.git backport: re PR middle-end/52547 (ICE with openmp with nested function which requires a trampoline) Backported from mainline 2012-03-22 Jakub Jelinek PR middle-end/52547 * tree-nested.c (convert_tramp_reference_stmt): Call declare_vars on any new_local_var_chain vars declared during recursing on GIMPLE_OMP_PARALLEL or GIMPLE_OMP_TASK body. * testsuite/libgomp.c/pr52547.c: New test. From-SVN: r197441 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 986e8e4d3ee3..31f944eefd58 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,6 +1,13 @@ 2013-04-03 Jakub Jelinek Backported from mainline + 2012-03-22 Jakub Jelinek + + PR middle-end/52547 + * tree-nested.c (convert_tramp_reference_stmt): Call declare_vars + on any new_local_var_chain vars declared during recursing on + GIMPLE_OMP_PARALLEL or GIMPLE_OMP_TASK body. + 2012-03-01 Jakub Jelinek PR tree-optimization/52445 diff --git a/gcc/tree-nested.c b/gcc/tree-nested.c index cebaf07f7847..f33a0ca4e771 100644 --- a/gcc/tree-nested.c +++ b/gcc/tree-nested.c @@ -1950,6 +1950,7 @@ static tree convert_tramp_reference_stmt (gimple_stmt_iterator *gsi, bool *handled_ops_p, struct walk_stmt_info *wi) { + struct nesting_info *info = (struct nesting_info *) wi->info; gimple stmt = gsi_stmt (*gsi); switch (gimple_code (stmt)) @@ -1962,16 +1963,33 @@ convert_tramp_reference_stmt (gimple_stmt_iterator *gsi, bool *handled_ops_p, for (i = 0; i < nargs; i++) walk_tree (gimple_call_arg_ptr (stmt, i), convert_tramp_reference_op, wi, NULL); + break; + } - *handled_ops_p = true; - return NULL_TREE; + case GIMPLE_OMP_PARALLEL: + case GIMPLE_OMP_TASK: + { + tree save_local_var_chain; + walk_gimple_op (stmt, convert_tramp_reference_op, wi); + save_local_var_chain = info->new_local_var_chain; + info->new_local_var_chain = NULL; + walk_body (convert_tramp_reference_stmt, convert_tramp_reference_op, + info, gimple_omp_body (stmt)); + if (info->new_local_var_chain) + declare_vars (info->new_local_var_chain, + gimple_seq_first_stmt (gimple_omp_body (stmt)), + false); + info->new_local_var_chain = save_local_var_chain; } + break; default: + *handled_ops_p = false; + return NULL_TREE; break; } - *handled_ops_p = false; + *handled_ops_p = true; return NULL_TREE; } diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 38c08ceffbb1..1480d9b103ae 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,11 @@ +2013-04-03 Jakub Jelinek + + Backported from mainline + 2012-03-22 Jakub Jelinek + + PR middle-end/52547 + * testsuite/libgomp.c/pr52547.c: New test. + 2012-03-01 Release Manager * GCC 4.6.3 released. diff --git a/libgomp/testsuite/libgomp.c/pr52547.c b/libgomp/testsuite/libgomp.c/pr52547.c new file mode 100644 index 000000000000..f746e2ec4690 --- /dev/null +++ b/libgomp/testsuite/libgomp.c/pr52547.c @@ -0,0 +1,36 @@ +/* PR middle-end/52547 */ +/* { dg-do run } */ + +extern void abort (void); + +__attribute__((noinline, noclone)) int +baz (int *x, int (*fn) (int *)) +{ + return fn (x); +} + +__attribute__((noinline, noclone)) int +foo (int x, int *y) +{ + int i, e = 0; +#pragma omp parallel for reduction(|:e) + for (i = 0; i < x; ++i) + { + __label__ lab; + int bar (int *z) { return z - y; } + if (baz (&y[i], bar) != i) + e |= 1; + } + return e; +} + +int +main () +{ + int a[100], i; + for (i = 0; i < 100; i++) + a[i] = i; + if (foo (100, a)) + abort (); + return 0; +}