From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 9 Dec 2020 08:28:43 +0000 (+0100)
Subject: confile: cleanup get_config_net_ipv4_gateway()
X-Git-Tag: lxc-5.0.0~330^2~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f203e57c7727a573e26e17a18993fe66b88cd2d0;p=thirdparty%2Flxc.git

confile: cleanup get_config_net_ipv4_gateway()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/confile.c b/src/lxc/confile.c
index c15934812..b1c922e04 100644
--- a/src/lxc/confile.c
+++ b/src/lxc/confile.c
@@ -5999,14 +5999,15 @@ static int get_config_net_ipv4_gateway(const char *key, char *retv, int inlen,
 		memset(retv, 0, inlen);
 
 	if (!netdev)
-		return -1;
+		return ret_errno(EINVAL);
 
 	if (netdev->ipv4_gateway_auto) {
 		strprint(retv, inlen, "auto");
 	} else if (netdev->ipv4_gateway_dev) {
 		strprint(retv, inlen, "dev");
 	} else if (netdev->ipv4_gateway) {
-		inet_ntop(AF_INET, netdev->ipv4_gateway, buf, sizeof(buf));
+		if (!inet_ntop(AF_INET, netdev->ipv4_gateway, buf, sizeof(buf)))
+			return -errno;
 		strprint(retv, inlen, "%s", buf);
 	}