From: Andrea Bolognani Date: Thu, 22 Jul 2021 13:37:25 +0000 (+0200) Subject: qemu: Allow pcie-expander-bus for aarch64/virt guests X-Git-Tag: v7.7.0-rc1~301 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f225ef2a04baa2d875c4bb6358958b8a6f82d58c;p=thirdparty%2Flibvirt.git qemu: Allow pcie-expander-bus for aarch64/virt guests Starting with QEMU 6.0, this controller is enabled by default on aarch64. https://bugzilla.redhat.com/show_bug.cgi?id=1967187 Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7e2efc8168..385d0c1526 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5222,10 +5222,10 @@ qemuDomainControllerDefPostParse(virDomainControllerDef *cont, return -1; } if (cont->model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_EXPANDER_BUS && - !qemuDomainIsQ35(def)) { + !(qemuDomainIsQ35(def) || qemuDomainIsARMVirt(def))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("pcie-expander-bus controllers are only supported " - "on q35-based machinetypes")); + _("pcie-expander-bus controllers are not supported " + "with this machine type")); return -1; } diff --git a/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err b/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err index 9b58aaddd6..06967dbbcd 100644 --- a/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err +++ b/tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err @@ -1 +1 @@ -unsupported configuration: pcie-expander-bus controllers are only supported on q35-based machinetypes +unsupported configuration: pcie-expander-bus controllers are not supported with this machine type