From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 4 Jun 2015 23:33:51 +0000 (-0600)
Subject: Request may be null
X-Git-Tag: release_3_0_9~258
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f235dbe2f5f5d60fde5ef8ba5e4f29e7ad5d54f9;p=thirdparty%2Ffreeradius-server.git

Request may be null
---

diff --git a/src/main/tls.c b/src/main/tls.c
index b3d49b71c05..d6e741f7078 100644
--- a/src/main/tls.c
+++ b/src/main/tls.c
@@ -452,7 +452,7 @@ static int int_ssl_check(REQUEST *request, SSL *s, int ret, char const *text)
 	if ((l = ERR_get_error()) != 0) {
 		char const *p = ERR_error_string(l, NULL);
 
-		if (request && p) REDEBUG("SSL says: %s", p);
+		if (p) ROPTIONAL(REDEBUG, ERROR, "SSL says: %s", p);
 	}
 	e = SSL_get_error(s, ret);
 
@@ -482,11 +482,11 @@ static int int_ssl_check(REQUEST *request, SSL *s, int ret, char const *text)
 		 *	being regarded as "dead".
 		 */
 	case SSL_ERROR_SYSCALL:
-		REDEBUG("%s failed in a system call (%d), TLS session failed", text, ret);
+		ROPTIONAL(REDEBUG, ERROR, "%s failed in a system call (%d), TLS session failed", text, ret);
 		return 0;
 
 	case SSL_ERROR_SSL:
-		REDEBUG("%s failed inside of TLS (%d), TLS session failed", text, ret);
+		ROPTIONAL(REDEBUG, ERROR, "%s failed inside of TLS (%d), TLS session failed", text, ret);
 		return 0;
 
 	default:
@@ -496,7 +496,7 @@ static int int_ssl_check(REQUEST *request, SSL *s, int ret, char const *text)
 		 *	them - so "politely inform" the caller that
 		 *	the code needs updating here.
 		 */
-		REDEBUG("FATAL SSL error: %d", e);
+		ROPTIONAL(REDEBUG, ERROR, "FATAL SSL error: %d", e);
 		return 0;
 	}