From: Volker Lendecke Date: Wed, 30 Nov 2022 13:23:26 +0000 (+0100) Subject: winbind: Save an intermediate NULL check with talloc_asprintf_addbuf() X-Git-Tag: talloc-2.4.0~245 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f25b6de771df587e58a28ae417bb5a2f596ec5a2;p=thirdparty%2Fsamba.git winbind: Save an intermediate NULL check with talloc_asprintf_addbuf() Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- diff --git a/source3/winbindd/winbindd_wins_byname.c b/source3/winbindd/winbindd_wins_byname.c index 2014714ff01..ae170b2e0b9 100644 --- a/source3/winbindd/winbindd_wins_byname.c +++ b/source3/winbindd/winbindd_wins_byname.c @@ -133,16 +133,13 @@ NTSTATUS winbindd_wins_byname_recv(struct tevent_req *req, char addr[INET6_ADDRSTRLEN]; print_sockaddr(addr, sizeof(addr), &state->addrs[i]); D_NOTICE("%zu: %s\n", i, addr); - response = talloc_asprintf_append_buffer( - response, "%s%s", addr, + talloc_asprintf_addbuf( + &response, "%s%s", addr, i < (state->num_addrs-1) ? " " : ""); - if (response == NULL) { - return NT_STATUS_NO_MEMORY; - } } - response = talloc_asprintf_append_buffer( - response, "\t%s\n", state->request->data.winsreq); + talloc_asprintf_addbuf( + &response, "\t%s\n", state->request->data.winsreq); if (response == NULL) { return NT_STATUS_NO_MEMORY; }