From: Allen, Timothy <tallen@wharton.upenn.edu>
Date: Thu, 28 May 2015 18:25:56 +0000 (-0700)
Subject: Update to correct TDS version; FreeTDS only supports up to 7.3. 8.0 is not a valid... 
X-Git-Tag: rel_0_9_10~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f2b1f04e83d2b9d83310d8957b95d23c54901160;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Update to correct TDS version; FreeTDS only supports up to 7.3. 8.0 is not a valid version (Microsoft released the spec late).

(cherry picked from commit 19571e2f8f4b621f3a1eaea198a8556497178015)
---

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index 7aab9556ef..4839d324f2 100644
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -1375,11 +1375,15 @@ class MSDialect(default.DefaultDialect):
             # FreeTDS with version 4.2 seems to report here
             # a number like "95.10.255".  Don't know what
             # that is.  So emit warning.
+            # Use TDS Version 7.0 through 7.3, per the MS information here:
+            # https://msdn.microsoft.com/en-us/library/dd339982.aspx
+            # and FreeTDS information here (7.3 highest supported version):
+            # http://www.freetds.org/userguide/choosingtdsprotocol.htm
             util.warn(
                 "Unrecognized server version info '%s'.   Version specific "
                 "behaviors may not function properly.   If using ODBC "
-                "with FreeTDS, ensure server version 7.0 or 8.0, not 4.2, "
-                "is configured in the FreeTDS configuration." %
+                "with FreeTDS, ensure TDS_VERSION 7.0 through 7.3, not "
+                "4.2, is configured in the FreeTDS configuration." %
                 ".".join(str(x) for x in self.server_version_info))
         if self.server_version_info >= MS_2005_VERSION and \
                 'implicit_returning' not in self.__dict__: