From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Wed, 1 Apr 2020 11:17:41 +0000 (+0200)
Subject: Remote Backend: 404 status codes in HTTP is fine
X-Git-Tag: dnsdist-1.5.0-rc3~26^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f2d90efc822839adf42d8ccc04d3565f1b205af9;p=thirdparty%2Fpdns.git

Remote Backend: 404 status codes in HTTP is fine

These might indicate that the function is not implemented
---

diff --git a/modules/remotebackend/httpconnector.cc b/modules/remotebackend/httpconnector.cc
index 675f1076b1..5aa3d2a69f 100644
--- a/modules/remotebackend/httpconnector.cc
+++ b/modules/remotebackend/httpconnector.cc
@@ -418,8 +418,9 @@ int HTTPConnector::recv_message(Json& output) {
 
     arl.finalize();
 
-    if (resp.status < 200 || resp.status >= 400) {
+    if ((resp.status < 200 || resp.status >= 400) && resp.status != 404) {
       // bad. 
+      g_log<<Logger::Warning<<"Received unacceptable HTTP status code "<<std::to_string(resp.status)<<" from HTTP endpoint"<<endl;
       return -1;
     }