From: Johann <johann.servoire@gmail.com>
Date: Sun, 19 Mar 2017 00:42:11 +0000 (+0100)
Subject: Fix getSelectorFromElement when # is a selector (#21615)
X-Git-Tag: v4.0.0-beta~147^2~146
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f2f2e39a45039658c3ed7a39af834ca8dd802bdc;p=thirdparty%2Fbootstrap.git

Fix getSelectorFromElement when # is a selector (#21615)

* Fix getSelectorFromElement when # is a selector

* Thanks to @vanduynslagerp remove regex to validate selector
---

diff --git a/js/src/util.js b/js/src/util.js
index 515eba6d9b..3c0d022513 100644
--- a/js/src/util.js
+++ b/js/src/util.js
@@ -112,13 +112,16 @@ const Util = (($) => {
 
     getSelectorFromElement(element) {
       let selector = element.getAttribute('data-target')
-
-      if (!selector) {
+      if (!selector || selector === '#') {
         selector = element.getAttribute('href') || ''
-        selector = /^#[a-z]/i.test(selector) ? selector : null
       }
 
-      return selector
+      try {
+        const $selector = $(selector)
+        return $selector.length > 0 ? selector : null
+      } catch (error) {
+        return null
+      }
     },
 
     reflow(element) {