From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 10 Nov 2025 15:54:32 +0000 (+0100)
Subject: virVBoxSnapshotConfSaveVboxFile: Don't modify deprecated 'xmlIndentTreeOutput'
X-Git-Tag: CVE-2025-12748~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f307c7dc0cdb5880fe75a4b0dab3cc76dc7b047e;p=thirdparty%2Flibvirt.git

virVBoxSnapshotConfSaveVboxFile: Don't modify deprecated 'xmlIndentTreeOutput'

'xmlIndentTreeOutput' is now deprecated by libxml2.

The default value set by libxml2 is '1', and the vbox driver resides
only inside the standalone daemon where the value will not be changed by
us thus there's no observable change in behaviour.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c
index b424648368..ff81cd0062 100644
--- a/src/vbox/vbox_snapshot_conf.c
+++ b/src/vbox/vbox_snapshot_conf.c
@@ -943,9 +943,6 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMachine *machine,
     g_auto(GStrv) secondRegex = NULL;
     int secondRegexResult = 0;
     const int parseFlags = XML_PARSE_NONET | XML_PARSE_NOBLANKS;
-    int oldIndentTreeOutput = xmlIndentTreeOutput;
-
-    xmlIndentTreeOutput = 1;
 
     if (machine == NULL) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -1127,8 +1124,6 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMachine *machine,
     ret = 0;
 
  cleanup:
-    xmlIndentTreeOutput = oldIndentTreeOutput;
-
     VIR_FREE(currentSnapshot);
     VIR_FREE(timeStamp);