From: Xiao Ni <xni@redhat.com>
Date: Fri, 26 Jul 2024 07:14:09 +0000 (+0800)
Subject: mdadm/mdopen: fix coverity issue CHECKED_RETURN
X-Git-Tag: mdadm-4.4~104
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f34040081c36ff92180674b89c39ddc7bdd47288;p=thirdparty%2Fmdadm.git

mdadm/mdopen: fix coverity issue CHECKED_RETURN

It needs to check return values when functions return value.

Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---

diff --git a/mdopen.c b/mdopen.c
index eaa59b59..c9fda131 100644
--- a/mdopen.c
+++ b/mdopen.c
@@ -406,7 +406,11 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy,
 				perror("chown");
 			if (chmod(devname, ci->mode))
 				perror("chmod");
-			stat(devname, &stb);
+			if (stat(devname, &stb) < 0) {
+				pr_err("failed to stat %s\n",
+						devname);
+				return -1;
+			}
 			add_dev(devname, &stb, 0, NULL);
 		}
 		if (use_mdp == 1)