From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 20 Jan 2026 11:06:51 +0000 (+0100)
Subject: dnsdist: Do not log from the TCP connection `dtor`
X-Git-Tag: rec-5.4.0-beta1~24^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f342848c909534b6e8031d03a3db7a29d0a143d8;p=thirdparty%2Fpdns.git

dnsdist: Do not log from the TCP connection `dtor`

It is not really useful and could throw.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
index 8548b072b3..45861c9c17 100644
--- a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
+++ b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
@@ -25,9 +25,8 @@ ConnectionToBackend::~ConnectionToBackend()
           g_sessionCache.putSessions(d_ds->getID(), now.tv_sec, std::move(sessions));
         }
       }
-      catch (const std::exception& e) {
-        VERBOSESLOG(infolog("Unable to get a TLS session: %s", e.what()),
-                    ConnectionToBackend::getLogger()->error(Logr::Info, e.what(), "Unable to get a TLS session"));
+      catch (const std::exception&) {
+        /* not much to do here */
       }
     }
     auto diff = now - d_connectionStartTime;