From: Andy Shevchenko Date: Thu, 29 Jan 2026 10:34:38 +0000 (+0100) Subject: i2c: designware: Remove dead code in AMD ISP case X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f35e16ec2ae964badf350cb6d4de6d81c6f3804d;p=thirdparty%2Flinux.git i2c: designware: Remove dead code in AMD ISP case The I²C bus shared with P-Unit is Intel only thing as far as I know. The AMD ISP driver has no relationship with P-Unit. Remove dead code that seems copied without much thinking. Signed-off-by: Andy Shevchenko Reviewed-by: Pratap Nirujogi Acked-by: Mika Westerberg Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260129103439.187478-1-andriy.shevchenko@linux.intel.com --- diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c index ec9259dd2a4f..c48728ad9f6f 100644 --- a/drivers/i2c/busses/i2c-designware-amdisp.c +++ b/drivers/i2c/busses/i2c-designware-amdisp.c @@ -18,9 +18,6 @@ static void amd_isp_dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *i2c_dev) { pm_runtime_disable(i2c_dev->dev); - - if (i2c_dev->shared_with_punit) - pm_runtime_put_noidle(i2c_dev->dev); } static inline u32 amd_isp_dw_i2c_get_clk_rate(struct dw_i2c_dev *i2c_dev) @@ -79,9 +76,6 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev) device_enable_async_suspend(&pdev->dev); - if (isp_i2c_dev->shared_with_punit) - pm_runtime_get_noresume(&pdev->dev); - pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); @@ -130,9 +124,6 @@ static int amd_isp_dw_i2c_plat_runtime_suspend(struct device *dev) { struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); - if (i_dev->shared_with_punit) - return 0; - i2c_dw_disable(i_dev); i2c_dw_prepare_clk(i_dev, false); @@ -161,9 +152,7 @@ static int amd_isp_dw_i2c_plat_runtime_resume(struct device *dev) if (!i_dev) return -ENODEV; - if (!i_dev->shared_with_punit) - i2c_dw_prepare_clk(i_dev, true); - + i2c_dw_prepare_clk(i_dev, true); i2c_dw_init(i_dev); return 0;