From: Michael Schroeder Date: Wed, 31 Oct 2018 12:02:28 +0000 (+0100) Subject: Fix off-by-one error in relation writing code X-Git-Tag: 0.7.1~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f35fb7a12a6d407fbee6e434c94a014527df125c;p=thirdparty%2Flibsolv.git Fix off-by-one error in relation writing code This tended to mess up the first relation in the solv file. Counting is hard sometimes... --- diff --git a/src/repo_write.c b/src/repo_write.c index a975cec8..d3b8a832 100644 --- a/src/repo_write.c +++ b/src/repo_write.c @@ -1637,7 +1637,7 @@ for (i = 1; i < target.nkeys; i++) /* we have some relations with a non-zero need */ Reldep *rd; - for (rd = pool->rels + i; i > 1; i--, rd--) + for (rd = pool->rels + i; i > 0; i--, rd--) { int need = needid[reloff + i].need; if (!need)